Fix Druid metadata refresh. #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
coleslaw
changed the title
| @@ -840,8 +840,12 @@ def latest_metadata(self): | |||
| return | |||
| max_time = results[0]['result']['maxTime'] | |||
| max_time = parse(max_time) | |||
| intervals = (max_time - timedelta(seconds=1)).isoformat() + '/' | |||
| intervals += (max_time + timedelta(seconds=1)).isoformat() | |||
| # Query segmentMetadata for 7 days back. However, due to a bug, | |||
There was a problem hiding this comment.
@mistercrunch I have to query [-7 day, -1 day] range because of a bug in 0.8.0. (see comment).
There was a problem hiding this comment.
why we need to query for 7 days? even 10 minutes is good enough
There was a problem hiding this comment.
Max has a point that some segment might be outside of the range. -7 is a heuristic to get at least one segment.
|
It's ready to be reviewed @mistercrunch @dayzzz |
|
LGTM ! merging. |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could you take a look @mistercrunch, in particular
dashed/models.py?