Trying POST instead of GET for testconn

apache · Sep 25, 2015 · f95e844 · f95e844
1 parent 83e37f6
commit f95e844
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 9 deletions.
diff --git a/panoramix/templates/appbuilder/baselayout.html b/panoramix/templates/appbuilder/baselayout.html
@@ -2,15 +2,17 @@
 {% import 'appbuilder/baselib.html' as baselib %}
 
 {% block body %}
-        {% include 'appbuilder/general/confirm.html' %}
-        {% include 'appbuilder/general/alert.html' %}
+    {% include 'appbuilder/general/confirm.html' %}
+    {% include 'appbuilder/general/alert.html' %}
 
     {% block navbar %}
         <header class="top" role="header">
         {% include 'appbuilder/navbar.html' %}
         </header>
     {% endblock %}
 
+    {% block uncontained %}{% endblock %}
+
     <div class="container">
       <div class="row">
           {% block messages %}
@@ -24,8 +26,6 @@
         {% block content_fluid %}
         {% endblock %}
     </div>
-    {% block uncontained %}
-    {% endblock %}
 
     {% block footer %}
         <footer>

diff --git a/panoramix/templates/panoramix/models/database/macros.html b/panoramix/templates/panoramix/models/database/macros.html
@@ -5,7 +5,7 @@
     $("#testconn").click(function() {
       var url = "/panoramix/testconn";
       $.ajax({
-        method: "GET",
+        method: "POST",
         url: url,
         data: { uri: $("#sqlalchemy_uri").val() }
       }).done(function() {

diff --git a/panoramix/views.py b/panoramix/views.py
@@ -326,12 +326,11 @@ def save_dash(self, dashboard_id):
         return "SUCCESS"
 
     @has_access
-    @expose("/testconn/")
+    @expose("/testconn", methods=["POST"])
     def testconn(self):
         try:
-            db = create_engine(request.args.get('uri'))
-            for i in range(15):
-                request.args.get('uri')
+            uri = request.form.get('uri')
+            db = create_engine(uri)
             db.connect()
             return "SUCCESS"
         except Exception as e: