Fixing 2 bugs that happen when fields are removed from table (#551)

apache · Jun 2, 2016 · b5614a4 · b5614a4
1 parent 5f005d6
commit b5614a4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/caravel/assets/javascripts/explore.js b/caravel/assets/javascripts/explore.js
@@ -237,7 +237,8 @@ function initExploreView() {
   function set_filters() {
     for (var i = 1; i < 10; i++) {
       var eq = px.getParam("flt_eq_" + i);
-      if (eq !== '') {
+      var col = px.getParam("flt_col_" + i);
+      if (eq !== '' && col !== '') {
         add_filter(i);
       }
     }

diff --git a/caravel/forms.py b/caravel/forms.py
@@ -52,7 +52,7 @@ def iter_choices(self):
             d[value] = (value, label, selected)
         if self.data:
             for value in self.data:
-                if value:
+                if value and value in d:
                     yield d.pop(value)
         while d:
             yield d.popitem(last=False)[1]