Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More web3 info from ethereum_common #19

Closed
khssnv opened this issue Aug 16, 2018 · 19 comments
Closed

More web3 info from ethereum_common #19

khssnv opened this issue Aug 16, 2018 · 19 comments

Comments

@khssnv
Copy link
Contributor

khssnv commented Aug 16, 2018

Hi!

I need a few more web3 things from the ethereum_common node.

  • current block number - to let lot publisher know where to start while computing deadline,
  • eth / token balance - to let CPS know its income,
  • approved amount - to check how much tokens already approved to liability factory and should I approve more for next operation.

Can you implement it or give a direction on how to do it? Seems like ERC20 node is not a place for things like balance or block number.

@akru
Copy link
Member

akru commented Aug 21, 2018

@gitcoinbot start work

@gitcoinbot
Copy link

gitcoinbot bot commented Aug 21, 2018

To show this bounty as started please visit this link

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.1 ETH (27.76 USD @ $277.56/ETH) attached to it.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Workers have applied to start work.

These users each claimed they can complete the work by 4 weeks from now.
Please review their action plans below:

  1. Rohithzr has applied to start work (Funders only: approve worker | reject worker) (1st dibs).

    so I have been working on web3js and web3py since last year and have seen it grow to what it is today lets take your issues for example.

current block number - there are many ways to know the block number from hash, address, contract address or just your node's current block.
eth / token balance - simple and straightforward for me.
approved amount - some more info needed

would need to dive in your code and understand what you really looking for so it will be beneficial to maybe have a small chat and discuss more on this.

Learn more on the Gitcoin Issue Details page.

  1. jlegha has applied to start work (Funders only: approve worker | reject worker) (2nd dibs).

    I am thinking for some methods to apply if they work.

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

@Rohithzr Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@Rohithzr
Copy link

just a bit of festive weekend in my country, Ill be back tomorrow and hopefully a PR in a couple of days

@Rohithzr
Copy link

@khssnv
I have very little information about this project at the moment so please let me know if the below solutions are not correct or why.

  1. current block :
def findBlockNumber():
	blockNumber = web3.eth.getBlock('latest')
	isSyncing = web3.eth.syncing
	if !isSyncing:
		blockNumber = web3.eth.syncing.currentBlock
	return blockNumber

@Rohithzr
Copy link

@khssnv which tokens are we supporting? ill make a function to get the balance. I would need some more elaboration on the approved amount issue.

@khssnv
Copy link
Contributor Author

khssnv commented Aug 29, 2018

Hi, @Rohithzr!

  1. Please consider how ERC20 node API made. It provides ROS Service. You may also make a topic publisher for periodical blockchain info,
  2. We support ERC20 tokens. Account Ether balance service getter also necessary,
  3. As I know, there is allowance erc20 function to check the rest of approved, you may use it.

@gitcoinbot
Copy link

@Rohithzr Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link

@Rohithzr Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@Rohithzr due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@Rohithzr due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@strdn strdn self-assigned this Oct 23, 2018
@rmshea
Copy link

rmshea commented Oct 25, 2018

@Rohithzr are you still working on this? Ryan from Gitcoin checking in.

strdn pushed a commit to strdn/robonomics_comm that referenced this issue Oct 25, 2018
strdn pushed a commit to strdn/robonomics_comm that referenced this issue Oct 25, 2018
strdn pushed a commit to strdn/robonomics_comm that referenced this issue Oct 26, 2018
@strdn strdn closed this as completed Oct 26, 2018
@rmshea
Copy link

rmshea commented Nov 8, 2018

Hey @strdn, should we close out the bounty on Gitcoin for this one?

@akru
Copy link
Member

akru commented Nov 8, 2018

Hey @ryan-shea, yes, close please, issue already implemented.

@spm32
Copy link

spm32 commented Nov 21, 2018

@akru you'll actually have to close out the issue here: https://gitcoin.co/issue/airalab/robonomics_comm/19/999

Thanks!

@rmshea
Copy link

rmshea commented Dec 10, 2018

@akru, issue closed!

@akru
Copy link
Member

akru commented Dec 10, 2018

@ryan-shea thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants