No HTTP transcoding for batch get nested request objects?

[bell-db]

AIP-231 allows nested request objects if

a field besides the resource name needs to be different between different resources being requested.

message BatchGetBooksRequest {
  // The requests specifying the books to retrieve.
  // A maximum of 1000 books can be retrieved in a batch.
  repeated GetBookRequest requests = 2
    [(google.api.field_behavior) = REQUIRED];
}

The same AIP also says

There must not be a body key in the google.api.http annotation.

Can we infer that requests are filled with query parameters? However, there seems no HTTP transcoding for repeated messages in query params:

Note that fields which are mapped to URL query parameters must have a primitive type or a repeated primitive type or a non-repeated message type.

[noahdietz]

Hi there, sorry for the late reply. You're right these things are at odds and when the guidance was changed in #281 to provide the "nested request message" as an alternative it was not updated to also say "use POST" though that is what was suggested and agreed upon in the relevant discussion: #203 (comment)

I think we need to change that...

[noahdietz]

In looking at all public GCP APIs, none of them have a nested request message BatchGet, so I think we should be good from our end to update the guidance without worrying about conflicting examples.

[bell-db]

Got it. Thanks for looking into it. Is there a PR to update AIP-231 according to this guideline?

[noahdietz]

Got it. Thanks for looking into it. Is there a PR to update AIP-231 according to this guideline?

There isn't one yet, no, please feel free to open one and ping me on it!