Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"No suggestions." box always present #7

Closed
hellmean opened this issue Jan 3, 2016 · 7 comments
Closed

"No suggestions." box always present #7

hellmean opened this issue Jan 3, 2016 · 7 comments

Comments

@hellmean
Copy link

hellmean commented Jan 3, 2016

the subj
the suggestWidget box is always present once you start typing in the INSERT mode, even if there is nothing to suggest (displaying 'No suggestions'). This is an abnormal behavior and does not occur when extension is inactive.

cheers!

@aioutecism
Copy link
Owner

Yes. This is a problem I haven't find a good solution.
I asked for keybinding service support in microsoft/vscode/issues/1432.
If you have any idea, please let me know.

@hellmean
Copy link
Author

hellmean commented Jan 4, 2016

all i can say is that this very strange as the two other plugins do exactly the same as yours, but for them this does not result in this behavior

@aioutecism
Copy link
Owner

74th's extension uses vscode's selections in normal mode, and only bind keys when there is no selections(Insert mode).
This solves the problem, but has weird apperance and cause the editor to be slow when editing large file.

I'll take a look into the other one.

@AndersenJ
Copy link

The other extention (vscodevim/Vim) has the same problem; IIRC they decided to wait until MS fixed this behavior.

@jpoon
Copy link

jpoon commented Jan 6, 2016

I'm the maintainer for vscodevim/Vim and just came across this project.

@AndersenJ we programatically show the auto-suggest window following each key press so we have the opposite problem. Rather than showing no auto-suggest window, we always show it, even if there is nothing: VSCodeVim/Vim#126

As an aside,

Because this and this are missing basic functions(such as multi-cursor support) I need. And they need a complete refactoring to meet my needs.

You are absolutely welcome to help contribute to vscodevim. Definitely would be better if we all invested our effort in making one of these extensions better rather than having the mentality: "nope this sucks, i'm going to write my own".

@aioutecism
Copy link
Owner

@jpoon

Apologize for the offensive words in readme(I edited them), didn't mean it.

I was going to contribute to 74th's extension. However, I found I need to modify almost every file in that project to meet my needs, and it's almost a rewrite.
I therefore decided creating a new one to save my efforts.

@aioutecism
Copy link
Owner

This should be solved in 1.0.0.
However, 1.0.0 depends on VSCode >= 0.10.12.
You can download the VSCode insiders version here and install amVim to try it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants