Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNM: attempt to speed up caching the split of the netloc #1427

Closed
wants to merge 1 commit into from
Closed

DNM: attempt to speed up caching the split of the netloc #1427

wants to merge 1 commit into from

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 20, 2024

No description provided.

@bdraco bdraco changed the title DNM: attempt to speed up caching the netloc DNM: attempt to speed up caching the split of the netloc Nov 20, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 20, 2024

CodSpeed Performance Report

Merging #1427 will degrade performances by 9.78%

Comparing cache_netloc (f20e162) with master (9f99a40)

Summary

❌ 1 regressions
✅ 84 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master cache_netloc Change
❌ test_raw_host_empty_cache 238.2 µs 264 µs -9.78%

@bdraco bdraco closed this Nov 20, 2024
@bdraco bdraco deleted the cache_netloc branch November 20, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bdraco