Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal _default_port property #1424

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Remove internal _default_port property #1424

merged 1 commit into from
Nov 20, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 20, 2024

What do these changes do?

Now that we have scheme available as self._scheme is should be a bit faster to avoid the extra property lookup, and a few less lines of code.

Screenshot 2024-11-19 at 10 01 55 PM Screenshot 2024-11-19 at 10 02 01 PM

Are there changes in behavior for the user?

no

Copy link

codspeed-hq bot commented Nov 20, 2024

CodSpeed Performance Report

Merging #1424 will not alter performance

Comparing remove_default_port (8e4c369) with master (a8d2556)

Summary

✅ 85 untouched benchmarks

@bdraco bdraco closed this Nov 20, 2024
@bdraco bdraco reopened this Nov 20, 2024
@bdraco
Copy link
Member Author

bdraco commented Nov 20, 2024

sigh codecov-action release broke ci
https://github.com/codecov/codecov-action/releases

@bdraco
Copy link
Member Author

bdraco commented Nov 20, 2024

Now that we have scheme available as self._scheme
is should be a bit faster to avoid the extra
property lookup
@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Nov 20, 2024
@bdraco bdraco changed the title Remove internal _default_port property Remove internal _default_port property Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.61%. Comparing base (57d69fe) to head (8e4c369).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1424      +/-   ##
==========================================
+ Coverage   96.05%   99.61%   +3.56%     
==========================================
  Files          31       23       -8     
  Lines        5774     4732    -1042     
  Branches      348      316      -32     
==========================================
- Hits         5546     4714     -832     
+ Misses        202       18     -184     
+ Partials       26        0      -26     
Flag Coverage Δ
CI-GHA 99.55% <100.00%> (+3.50%) ⬆️
MyPy ?
OS-Linux 99.55% <100.00%> (-0.01%) ⬇️
OS-Windows 99.61% <100.00%> (-0.01%) ⬇️
OS-macOS 99.30% <100.00%> (-0.01%) ⬇️
Py-3.10.11 99.28% <100.00%> (-0.01%) ⬇️
Py-3.10.15 99.51% <100.00%> (-0.01%) ⬇️
Py-3.11.10 99.51% <100.00%> (-0.01%) ⬇️
Py-3.11.9 99.28% <100.00%> (-0.01%) ⬇️
Py-3.12.7 99.51% <100.00%> (-0.01%) ⬇️
Py-3.13.0 99.51% <100.00%> (-0.01%) ⬇️
Py-3.9.13 99.23% <100.00%> (-0.01%) ⬇️
Py-3.9.20 99.47% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.16 99.53% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.17 99.55% <100.00%> (-0.01%) ⬇️
VM-macos-latest 99.30% <100.00%> (-0.01%) ⬇️
VM-ubuntu-latest 99.55% <100.00%> (-0.01%) ⬇️
VM-windows-latest 99.61% <100.00%> (-0.01%) ⬇️
pytest 99.55% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@bdraco bdraco marked this pull request as ready for review November 20, 2024 14:02
@bdraco bdraco enabled auto-merge (squash) November 20, 2024 14:03
@bdraco bdraco merged commit 9f99a40 into master Nov 20, 2024
44 of 45 checks passed
@bdraco bdraco deleted the remove_default_port branch November 20, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant