-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove internal _default_port
property
#1424
Conversation
CodSpeed Performance ReportMerging #1424 will not alter performanceComparing Summary
|
sigh codecov-action release broke ci |
Now that we have scheme available as self._scheme is should be a bit faster to avoid the extra property lookup
e5e99ed
to
8e4c369
Compare
_default_port
property
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1424 +/- ##
==========================================
+ Coverage 96.05% 99.61% +3.56%
==========================================
Files 31 23 -8
Lines 5774 4732 -1042
Branches 348 316 -32
==========================================
- Hits 5546 4714 -832
+ Misses 202 18 -184
+ Partials 26 0 -26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
What do these changes do?
Now that we have scheme available as
self._scheme
is should be a bit faster to avoid the extra property lookup, and a few less lines of code.Are there changes in behavior for the user?
no