-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yarl tests fail with python3.8 #410
Comments
While this is a change in CPython that may be reverted eventually in 3.8.2, it looks like it will persist in the further Python versions (3.9+). So YARL will need a version-dependent patch to properly detect the implementation (maybe feature-detect it) and keep the behavior consistent across versions. @makefu I suppose you could temporarily add a patch with |
P.S. The current CI is green because it still uses 3.8.0 |
Python 3.7.6 is affected too. |
PS: My patch for Gentoo: |
I just cloned the repository (commit 9afd40d) and running
Full output
|
The most relevant upstream bug is: https://bugs.python.org/issue27657 The change was reverted in 3.7 and 3.8. There is still some ongoing discussion whether 3.9 should do it but IMHO the new behavior will stay as it's standards-compliant and results in simpler code. An open question is how to achieve consistency — I suppose someone will eventually create a backport of the new parsing logic. |
Fixed by #409 |
One python Test is failing with python3.8, is this a global issue or could our distribution skip the tests?
The issue seems to exist at least since yarl-1.3.0
We are tracking the issue in NixOS/nixpkgs#75663
The text was updated successfully, but these errors were encountered: