-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
async_q.join() sometimes never return #75
Conversation
…e via sync_q.put()
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
==========================================
- Coverage 98.63% 98.63% -0.01%
==========================================
Files 1 1
Lines 294 293 -1
Branches 41 41
==========================================
- Hits 290 289 -1
Misses 2 2
Partials 2 2
Continue to review full report at Codecov.
|
Change looks good, is there any way to construct test case that reproduces issue? |
@jettify |
tests/test_mixed.py
Outdated
|
||
@asyncio.coroutine | ||
def do_work(): | ||
yield from asyncio.sleep(1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add loop=self.loop
here? Looks like this is reason why on 3.4 test stuck.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, thanks for pointing this out 👍
Thanks a lot! |
async_q.join() will never return in case when tasks are added to queue via sync_q.put()