Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clean fix for cancelation on 3.9+. #235

Closed
wants to merge 7 commits into from
Closed

Conversation

Dreamsorcerer
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (97161bf) to head (dbec807).
Report is 147 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #235   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          107       115    +8     
  Branches        16        18    +2     
=========================================
+ Hits           107       115    +8     
Flag Coverage Δ
unit 96.52% <85.71%> (-1.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@webknjaz
Copy link
Member

@Dreamsorcerer do you want to resurrect this effort?

@webknjaz
Copy link
Member

Is it related to #295?

@Dreamsorcerer
Copy link
Member Author

@Dreamsorcerer do you want to resurrect this effort?

I will return to this in some form, and verify if the problem is actually fixed in asyncio.timeout() or not. But, this library itself should probably be deprecated (and archived once asyncio.timeout() is available in all supported versions of Python).

Is it related to #295?

Yes, I'm pretty sure that PR is incorrect, as explained in my comments.

@asvetlov
Copy link
Member

Version 5.0+ wiorks exactly as asyncio built-in does, nothing to do here.

@asvetlov asvetlov closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants