Modify _drain_helper() to handle parallel calls without race-condition #6028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…out race-condition.
psf-chronographer
bot
added
the
bot:chronographer:provided
asvetlov
requested changes
Oct 6, 2021
Codecov Report
@@ Coverage Diff @@
## master #6028 +/- ##
==========================================
+ Coverage 93.32% 96.72% +3.39%
==========================================
Files 102 44 -58
Lines 30140 9857 -20283
Branches 2696 1593 -1103
==========================================
- Hits 28129 9534 -18595
+ Misses 1837 183 -1654
+ Partials 174 140 -34
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
asvetlov
reviewed
Oct 27, 2021
asvetlov
approved these changes
Oct 27, 2021
Backport to 3.8: 💚 backport PR created✅ Backport PR branch: Backported as #6146 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Oct 27, 2021
#6028) * Modify _drain_helper() to handle parallel calls of _send_frame() without race-condition. * Update CHANGES/2934.bugfix * Update 2934.bugfix Co-authored-by: Andrew Svetlov <[email protected]> (cherry picked from commit 3eea7b8)
5 tasks
aio-libs-github-bot bot
pushed a commit
that referenced
this pull request
Oct 27, 2021
#6028) * Modify _drain_helper() to handle parallel calls of _send_frame() without race-condition. * Update CHANGES/2934.bugfix * Update 2934.bugfix Co-authored-by: Andrew Svetlov <[email protected]>
💚 Backport successfulThe PR was backported to the following branches:
|
asvetlov
added a commit
that referenced
this pull request
Oct 27, 2021
#6028) (#6147) * Modify _drain_helper() to handle parallel calls of _send_frame() without race-condition. * Update CHANGES/2934.bugfix * Update 2934.bugfix Co-authored-by: Andrew Svetlov <[email protected]> Co-authored-by: Nándor Mátravölgyi <[email protected]> Co-authored-by: Andrew Svetlov <[email protected]>
asvetlov
pushed a commit
that referenced
this pull request
Oct 27, 2021
#6028) (#6146) * Modify _drain_helper() to handle parallel calls of _send_frame() without race-condition. * Update CHANGES/2934.bugfix * Update 2934.bugfix Co-authored-by: Andrew Svetlov <[email protected]> (cherry picked from commit 3eea7b8) Co-authored-by: Nándor Mátravölgyi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
These changes fix a bug/race-condition on the BaseProtocol's drain-waiter.
Are there changes in behavior for the user?
There are no API or behavioral changes. This should exclusively handle the case of the race-condition when multiple coroutines produce messages to a websocket for example.
Related issue number
This fix is aimed at the #2934 issue directly.
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.