5518 fix references in the abc.rst doc #5591
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l1storez
changed the title
|
I close the request because I lost access to the branch |
|
@l1storez I suppose you merely forgot to rebase this branch on top of the upstream master. |
webknjaz
reviewed
Apr 6, 2021
| :class:`AbstractRouter` has the only mandatory method: | ||
| :meth:`AbstractRouter.resolve` coroutine. It must return an | ||
| :class:`AbstractMatchInfo` instance. | ||
| :class:`aiohttp.abc.aiohttp.abc.AbstractRouter` has the only mandatory method: |
There was a problem hiding this comment.
these lines contain duplicate text
There was a problem hiding this comment.
:py:class:aiohttp.abc.aiohttp.abc.AbstractRouter from https://webknjaz.github.io/intersphinx-untangled/docs.aiohttp.org/
There was a problem hiding this comment.
Oh, wow. Sounds like there's some bug in how those docs are linked. Okay, leave it be.
|
I did rebase but I had history problems and "CI/ Linter error". Also, I lost access to the branch after checkout on the master. Because my "origin" was "my fork" |
|
New PR: #5610 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This change corrects multiple unrendered intersphinx class reference in the
abc.rstdocument.Are there changes in behavior for the user?
No
Related issue number
#5518
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.