Annotate all attrs members #5115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In py.typed packages, public attributes must be explicitly typed. This is not an issue for mypy because the attrs mypy plug-in is able to infer the types of attrs dynamically. However, in other static type checkers, like Pyright and pytype, the type of unannotated attrs is not known statically. Since aiohttp no longer supports Python versions older than 3.6 I've taken the liberty of converting the annotations to the native format.
psf-chronographer
bot
added
the
bot:chronographer:provided
asvetlov
approved these changes
Oct 24, 2020
💔 Backport was not successfulThe PR was attempted backported to the following branches:
|
asvetlov
pushed a commit
that referenced
this pull request
Oct 24, 2020
* Annotate all attrs members In py.typed packages, public attributes must be explicitly typed. This is not an issue for mypy because the attrs mypy plug-in is able to infer the types of attrs dynamically. However, in other static type checkers, like Pyright and pytype, the type of unannotated attrs is not known statically. Since aiohttp no longer supports Python versions older than 3.6 I've taken the liberty of converting the annotations to the native format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
In py.typed packages, public attributes must be explicitly typed.
This is not an issue for mypy because the attrs mypy plug-in is able
to infer the types of attrs dynamically. However, in other
static type checkers, like Pyright and pytype, the type of
unannotated attrs is not known statically.
Since aiohttp no longer supports Python versions older than 3.6
I've taken the liberty of converting the annotations to the native
format.
Are there changes in behavior for the user?
No.
Related issue number
—
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.