Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Url GET parameters are lost when redirecting #499

Closed
squaredbeaver opened this issue Sep 10, 2015 · 5 comments
Closed

Url GET parameters are lost when redirecting #499

squaredbeaver opened this issue Sep 10, 2015 · 5 comments
Labels
Milestone

Comments

@squaredbeaver
Copy link

What's the purpose of trimming get parameters here?

@asvetlov
Copy link
Member

I believe the intention was removing just fragment part (#achor).
But it's also questionable.
I'm fine with leaving location untouched.

@fafhrd91 looks like it's your code. Do you remember details?

@asvetlov asvetlov added this to the 0.18 milestone Sep 19, 2015
@asvetlov
Copy link
Member

@fafhrd91
Copy link
Member

Sure, I actually do not remember reason for this code

@asvetlov
Copy link
Member

Done!

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants