Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate accepting bool in resp.enable_compression() #3318

Closed
asvetlov opened this issue Oct 3, 2018 · 5 comments
Closed

Deprecate accepting bool in resp.enable_compression() #3318

asvetlov opened this issue Oct 3, 2018 · 5 comments
Labels
good first issue Good for newcomers Hacktoberfest We think it's good for https://hacktoberfest.digitalocean.com/ outdated server

Comments

@asvetlov
Copy link
Member

asvetlov commented Oct 3, 2018

bool is discouraged for very long time (3 years?) but we need a formal deprecation before the feature removing.
@asvetlov asvetlov added good first issue Good for newcomers server labels Oct 3, 2018
@aio-libs-bot
Copy link

GitMate.io thinks possibly related issues are #1108 (Deprecate aiohttp.wsgi), #3260 (Deprecate stream.unread_data), #1322 (Properly parse Accept-Encoding), #1160 (Deprecate old websocket specs), and #1658 (Remove deprecated api).

@webknjaz webknjaz added the Hacktoberfest We think it's good for https://hacktoberfest.digitalocean.com/ label Oct 3, 2018
@OisinA
Copy link
Contributor

OisinA commented Oct 4, 2018

Done in the following PR: https://github.com/aio-libs/aiohttp/pull/3322

@gyermolenko
Copy link
Contributor

proper link to PR #3322

@asvetlov
Copy link
Member Author

Fixed by #3322

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers Hacktoberfest We think it's good for https://hacktoberfest.digitalocean.com/ outdated server
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@asvetlov @webknjaz @OisinA @gyermolenko @aio-libs-bot