Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warnings in 3.8 #3273

Closed
wumpus opened this issue Sep 17, 2018 · 5 comments
Closed

Deprecation warnings in 3.8 #3273

wumpus opened this issue Sep 17, 2018 · 5 comments

Comments

@wumpus
Copy link

wumpus commented Sep 17, 2018

/home/travis/virtualenv/python3.8-dev/lib/python3.8/site-packages/aiohttp/multipart.py:8: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
from collections import Mapping, Sequence, deque

This is a safe change to make, collections.abc was introduced in 3.3.

@asvetlov
Copy link
Member

GitMate.io thinks possibly related issues are #3252 (False-positive deprecation warning for partial async handlers), #1575 (Deprecation policy), #130 (Multiple Test Warnings on Python 3.4 (ResourceWarning / DeprecationWarning)), #2670 ([injection] 2.3.8 broke certain regex match patterns), and #1603 (1.3 Release).

@asvetlov asvetlov added the bug label Sep 17, 2018
@augustogoulart
Copy link
Contributor

augustogoulart commented Sep 18, 2018

I'm getting the same warnings while writing tests for an application using Python 3.7 and pytest 3.8.0.
@wumpus do you have plans to work on that? If not, I would like to work on a patch for it. Thanks.

@wumpus
Copy link
Author

wumpus commented Sep 18, 2018

Please do the patch! It's quite easy.

@Harmon758
Copy link
Member

This specific line should already be fixed with #3258 (c8c0567).

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants