Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make chardet dependency mandatory #318

Closed
asvetlov opened this issue Apr 11, 2015 · 5 comments
Closed

Make chardet dependency mandatory #318

asvetlov opened this issue Apr 11, 2015 · 5 comments
Labels
outdated

Comments

@asvetlov
Copy link
Member

Why not?
aiohttp should be installed from PyPI anyway.
chardet is pretty stable.
We can add extra dependency to setup.py, cleanup code a bit and drop redundant tests.
@fafhrd91
Copy link
Member

Ok. I am fine with that

@asvetlov
Copy link
Member Author

I'll do then

@ludovic-gasc
Copy link
Contributor

It's a good idea.

@asvetlov
Copy link
Member Author

Done in b38fdf5

@aio-libs-bot aio-libs-bot mentioned this issue Oct 15, 2018
Closed
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ludovic-gasc @asvetlov @fafhrd91