Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sock read timeout #3055

Merged
merged 2 commits into from
Jun 5, 2018
Merged

Fix sock read timeout #3055

merged 2 commits into from
Jun 5, 2018

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Jun 5, 2018

Fix #3053

@codecov-io
Copy link

codecov-io commented Jun 5, 2018

Codecov Report

Merging #3055 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3055      +/-   ##
==========================================
+ Coverage   98.11%   98.11%   +<.01%     
==========================================
  Files          42       42              
  Lines        7739     7743       +4     
  Branches     1348     1349       +1     
==========================================
+ Hits         7593     7597       +4     
  Misses         51       51              
  Partials       95       95
Impacted Files Coverage Δ
aiohttp/client_proto.py 95.94% <100%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdf3806...038ef93. Read the comment docs.

@asvetlov asvetlov merged commit e641373 into master Jun 5, 2018
@asvetlov asvetlov deleted the fix-sock_read-timeout branch June 5, 2018 16:55
asvetlov added a commit that referenced this pull request Jun 5, 2018
* Fix sock_read timeout

* Add changelog
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.3 socket read timeouts not working correctly
2 participants