Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add canonical name for the route #2968

Closed
jettify opened this issue Apr 30, 2018 · 2 comments · Fixed by #2993
Closed

Add canonical name for the route #2968

jettify opened this issue Apr 30, 2018 · 2 comments · Fixed by #2993
Labels
enhancement good first issue Good for newcomers need pull request outdated server sprint

Comments

@jettify
Copy link
Member

jettify commented Apr 30, 2018

Long story short

For third party libraries sometimes it is useful to know canonical name of the route from request, for example aio-libs/aiozipkin#115.

Something like /foo/bar/{name:\d+} could be exposed with property: request.match_info.route.canonical_name

Actual behaviour

Steps to reproduce

Your environment
@jettify jettify mentioned this issue Apr 30, 2018
Closed
@asvetlov asvetlov added the good first issue Good for newcomers label May 2, 2018
@asvetlov
Copy link
Member

asvetlov commented May 2, 2018

Let's use a formatter pattern from .url_for() implementation.

The issue is easy to implement, looking for a champion.

pposca added a commit to pposca/aiohttp that referenced this issue May 11, 2018
@pposca
Add path_pattern property to routes and resources
9253be8 
The path_pattern is the raw path used to add a new route. For example,
/foo/bar/{name:\d+}.

 - Add path_pattern property to AbstractRoute and AbstractResource
 - Add path pattern implementation to PlainResource, DynamicResource,
 PrefixResource, StaticResource, ResourceRoute and SystemRoute.
 - Add tests

Closes aio-libs#2968
pposca added a commit to pposca/aiohttp that referenced this issue May 11, 2018
@pposca
Add path_pattern property to routes and resources
1f449e1 
The path_pattern is the raw path used to add a new route. For example,
/foo/bar/{name:\d+}.

 - Add path_pattern property to AbstractRoute and AbstractResource
 - Add path pattern implementation to PlainResource, DynamicResource,
 PrefixResource, StaticResource, ResourceRoute and SystemRoute.
 - Add tests

Closes aio-libs#2968
@pposca pposca mentioned this issue May 11, 2018
Merged
5 tasks
pposca added a commit to pposca/aiohttp that referenced this issue May 21, 2018
@pposca
Add canonical property to routes and resources
35b5704 
The canonical is the path used to add a new route. For example,
/foo/bar/{name}. For DynamicResource, canonical exposes the
formatter.

 - Add canonical property to AbstractRoute and AbstractResource
 - Add canonical implementation to PlainResource, DynamicResource,
 PrefixResource, StaticResource, ResourceRoute and SystemRoute.
 - Add tests

Closes aio-libs#2968
pposca added a commit to pposca/aiohttp that referenced this issue May 22, 2018
@pposca
Add canonical property to resources
e84d6ed 
The canonical is the path used to add a new route. For example,
/foo/bar/{name}. For DynamicResource, canonical exposes the
formatter.

 - Add canonical property to AbstractResource
 - Add canonical implementation to PlainResource, DynamicResource,
 PrefixResource and StaticResource.
 - Add tests
 - Add docs

Closes aio-libs#2968
pposca added a commit to pposca/aiohttp that referenced this issue May 23, 2018
@pposca
Add canonical property to resources
d43cd9b 
The canonical is the path used to add a new route. For example,
/foo/bar/{name}. For DynamicResource, canonical exposes the
formatter.

 - Add canonical property to AbstractResource
 - Add canonical implementation to DynamicResource, PrefixResource
 and StaticResource.
 - Add tests
 - Add docs

Closes aio-libs#2968
pposca added a commit to pposca/aiohttp that referenced this issue May 24, 2018
@pposca
Add canonical property to resources
5ff1917 
The canonical is the path used to add a new route. For example,
/foo/bar/{name}. For DynamicResource, canonical exposes the
formatter.

 - Add canonical property to AbstractResource
 - Add canonical implementation to DynamicResource, PrefixResource
 and StaticResource.
 - Add tests
 - Add docs

Closes aio-libs#2968
asvetlov pushed a commit that referenced this issue May 27, 2018
@pposca @asvetlov
Add canonical property to resources (#2993)
0e11b36 
The canonical is the path used to add a new route. For example,
/foo/bar/{name}. For DynamicResource, canonical exposes the
formatter.

Closes #2968
@dependencies dependencies bot mentioned this issue Jun 2, 2018
Closed
kornicameister referenced this issue in kornicameister/korni-stats-collector Jun 7, 2018
@pyup-bot @kornicameister
Update aiohttp to 3.3.1 (#78)
74c1f03 
This PR updates [aiohttp](https://pypi.org/project/aiohttp) from **3.2.1** to **3.3.1**.



<details>
  <summary>Changelog</summary>
  
  
   ### 3.3.0
   ```
   ==================

Features
--------

- Raise ``ConnectionResetError`` instead of ``CancelledError`` on trying to
  write to a closed stream. (`2499 &lt;https://github.com/aio-libs/aiohttp/pull/2499&gt;`_)
- Implement ``ClientTimeout`` class and support socket read timeout. (`2768 &lt;https://github.com/aio-libs/aiohttp/pull/2768&gt;`_)
- Enable logging when ``aiohttp.web`` is used as a program (`2956 &lt;https://github.com/aio-libs/aiohttp/pull/2956&gt;`_)
- Add canonical property to resources (`2968 &lt;https://github.com/aio-libs/aiohttp/pull/2968&gt;`_)
- Forbid reading response BODY after release (`2983 &lt;https://github.com/aio-libs/aiohttp/pull/2983&gt;`_)
- Implement base protocol class to avoid a dependency from internal
  ``asyncio.streams.FlowControlMixin`` (`2986 &lt;https://github.com/aio-libs/aiohttp/pull/2986&gt;`_)
- Cythonize ``helpers.reify``, 5% boost on macro benchmark (`2995 &lt;https://github.com/aio-libs/aiohttp/pull/2995&gt;`_)
- Optimize HTTP parser (`3015 &lt;https://github.com/aio-libs/aiohttp/pull/3015&gt;`_)
- Implement ``runner.addresses`` property. (`3036 &lt;https://github.com/aio-libs/aiohttp/pull/3036&gt;`_)
- Use ``bytearray`` instead of a list of ``bytes`` in websocket reader. It
  improves websocket message reading a little. (`3039 &lt;https://github.com/aio-libs/aiohttp/pull/3039&gt;`_)
- Remove heartbeat on closing connection on keepalive timeout. The used hack
  violates HTTP protocol. (`3041 &lt;https://github.com/aio-libs/aiohttp/pull/3041&gt;`_)
- Limit websocket message size on reading to 4 MB by default. (`3045 &lt;https://github.com/aio-libs/aiohttp/pull/3045&gt;`_)


Bugfixes
--------

- Don&#39;t reuse a connection with the same URL but different proxy/TLS settings
  (`2981 &lt;https://github.com/aio-libs/aiohttp/pull/2981&gt;`_)
- When parsing the Forwarded header, the optional port number is now preserved.
  (`3009 &lt;https://github.com/aio-libs/aiohttp/pull/3009&gt;`_)


Improved Documentation
----------------------

- Make Change Log more visible in docs (`3029 &lt;https://github.com/aio-libs/aiohttp/pull/3029&gt;`_)
- Make style and grammar improvements on the FAQ page. (`3030 &lt;https://github.com/aio-libs/aiohttp/pull/3030&gt;`_)
- Document that signal handlers should be async functions since aiohttp 3.0
  (`3032 &lt;https://github.com/aio-libs/aiohttp/pull/3032&gt;`_)


Deprecations and Removals
-------------------------

- Deprecate custom application&#39;s router. (`3021 &lt;https://github.com/aio-libs/aiohttp/pull/3021&gt;`_)


Misc
----

- 3008, 3011
   ```
   
  
</details>


 

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/aiohttp
  - Changelog: https://pyup.io/changelogs/aiohttp/
  - Repo: https://github.com/aio-libs/aiohttp
</details>
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement good first issue Good for newcomers need pull request outdated server sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add path_pattern property to routes and resources pposca/aiohttp
2 participants
@jettify @asvetlov