Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix async with in TestClient.ws_connect #2528

Merged
merged 5 commits into from
Nov 18, 2017

Conversation

barrachri
Copy link

What do these changes do?

Add async with support for TestClient.ws_connect

Are there changes in behavior for the user?

No

Related issue number

#2525

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bug)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@barrachri barrachri force-pushed the fix_async_with_#2525 branch from 0969027 to 8b28ac9 Compare November 17, 2017 10:39
@samuelcolvin
Copy link
Member

Issue numbers in titles don't work as links and generally don't mean much to people.

Best to use a short descriptive title and add the issue number to the body.

@barrachri barrachri changed the title WIP fix#2525 fix async with in TestClient Nov 17, 2017
@barrachri barrachri changed the title fix async with in TestClient fix async with in TestClient.ws_connect Nov 17, 2017
@barrachri
Copy link
Author

Thanks, should be more expressive now.

@asvetlov
Copy link
Member

The change looks good but worth for a new test for added functionality.
tests/test_test_utils.py already has a test for await TestClient.ws_connect(), adding a new one for async with TestClient.ws_connect() should be easy.

@codecov-io
Copy link

codecov-io commented Nov 18, 2017

Codecov Report

Merging #2528 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2528      +/-   ##
==========================================
+ Coverage   97.13%   97.13%   +<.01%     
==========================================
  Files          39       39              
  Lines        8068     8070       +2     
  Branches     1415     1415              
==========================================
+ Hits         7837     7839       +2     
  Misses         99       99              
  Partials      132      132
Impacted Files Coverage Δ
aiohttp/test_utils.py 98.23% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b39600f...6098169. Read the comment docs.

@asvetlov asvetlov merged commit 278d5d5 into aio-libs:master Nov 18, 2017
@asvetlov
Copy link
Member

thanks!

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants