From fae4cba959c2cd006638d2155a095650c05c25dd Mon Sep 17 00:00:00 2001 From: Jair Henrique Date: Mon, 23 Oct 2017 08:00:25 -0200 Subject: [PATCH] drop resolve param from TCPConnector --- CHANGES/2377.removal | 1 + aiohttp/connector.py | 4 +--- tests/test_client_functional.py | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) create mode 100644 CHANGES/2377.removal diff --git a/CHANGES/2377.removal b/CHANGES/2377.removal new file mode 100644 index 00000000000..8f38172c17a --- /dev/null +++ b/CHANGES/2377.removal @@ -0,0 +1 @@ +Drop `resolve` param from TCPConnector. diff --git a/aiohttp/connector.py b/aiohttp/connector.py index 2415e9250a4..71f151987f2 100644 --- a/aiohttp/connector.py +++ b/aiohttp/connector.py @@ -563,8 +563,6 @@ class TCPConnector(BaseConnector): digest of the expected certificate in DER format to verify that the certificate the server presents matches. See also https://en.wikipedia.org/wiki/Transport_Layer_Security#Certificate_pinning - resolve - (Deprecated) Set to True to do DNS lookup for - host name. resolver - Enable DNS lookups and use this resolver use_dns_cache - Use memory cache for DNS lookups. @@ -581,7 +579,7 @@ class TCPConnector(BaseConnector): """ def __init__(self, *, verify_ssl=True, fingerprint=None, - resolve=sentinel, use_dns_cache=True, ttl_dns_cache=10, + use_dns_cache=True, ttl_dns_cache=10, family=0, ssl_context=None, local_addr=None, resolver=None, keepalive_timeout=sentinel, force_close=False, limit=100, limit_per_host=0, diff --git a/tests/test_client_functional.py b/tests/test_client_functional.py index 8f5b0f8bf7d..7bd2420b07c 100644 --- a/tests/test_client_functional.py +++ b/tests/test_client_functional.py @@ -744,7 +744,7 @@ async def test_HTTP_200_OK_METHOD_connector(loop, test_client): async def handler(request): return web.Response(text=request.method) - conn = aiohttp.TCPConnector(resolve=True, loop=loop) + conn = aiohttp.TCPConnector(loop=loop) conn.clear_dns_cache() app = web.Application()