Should wsgi.py unquote path?

[asvetlov]

See line https://github.com/KeepSafe/aiohttp/blob/master/aiohttp/wsgi.py#L131
Current code produces error in gunicorn: benoitc/gunicorn#930

IIRC WSGI standard doesn't specifies path unquoting. WSGI library implementations unquotes param internally assuming environ['PATH_INFO'] is not unquoted string.

Any objections to unquote removing? @fafhrd91 ?

[fafhrd91]

+1

On Wednesday, November 19, 2014, Andrew Svetlov [email protected]
wrote:

See line
https://github.com/KeepSafe/aiohttp/blob/master/aiohttp/wsgi.py#L131
Current code produces error in gunicorn: benoitc/gunicorn#930
benoitc/gunicorn#930

IIRC WSGI standard doesn't specifies path unquoting. WSGI library
implementations unquotes param internally assuming environ['PATH_INFO']
is not unquoted string.

Any objections to unquote removing? @fafhrd91
https://github.com/fafhrd91 ?

—
Reply to this email directly or view it on GitHub
#177.

[jgehrcke]

So, according to the discussions in benoitc/gunicorn#1211 it looks like aiohttp's wsgi implementation should do path unquoting, as does Werkzeug and wsgiref.

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.