Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad data type in update_body_from_data #1306

Closed
demmsnt opened this issue Oct 12, 2016 · 3 comments
Closed

Bad data type in update_body_from_data #1306

demmsnt opened this issue Oct 12, 2016 · 3 comments
Labels

Comments

@demmsnt
Copy link
Contributor

demmsnt commented Oct 12, 2016

https://github.com/KeepSafe/aiohttp/blob/master/aiohttp/client_reqrep.py#L260

i see elif not self.chunked and isinstance(data, io.BufferedReader):

But using aiobotocore i try

    resp = yield from client.put_object(Bucket=bucket,
                                        Key=key,
                                        Body=open('ANONYMIZE.zip', 'r+b'))

Type of Body is io.BufferedRandom

I replace code to

elif not self.chunked and (isinstance(data, io.BufferedReader) or isinstance(data, io.BufferedRandom)):

And that fix problem.

@asvetlov asvetlov added the good first issue Good for newcomers label Oct 14, 2016
@asvetlov
Copy link
Member

Got it.
Would you create a PR?
isinstance(data, io.BufferedReader) or isinstance(data, io.BufferedRandom) could be replaced with isinstance(data, (io.BufferedReader, io.BufferedRandom)).
A functional test is required (just sending a file opened with 'r+b' mode should be enough).

@asvetlov
Copy link
Member

Fixed by #1312

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants