-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flake8-docstrings, fix bunch of flagged issues #6276
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Codecov Report
@@ Coverage Diff @@
## master #6276 +/- ##
=======================================
Coverage 93.30% 93.30%
=======================================
Files 103 103
Lines 30362 30362
Branches 2729 2729
=======================================
Hits 28328 28328
Misses 1857 1857
Partials 177 177
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Backport to 3.8: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 47ff9b3 on top of patchback/backports/3.8/47ff9b358bb6147353b1b37b0ac18d641df9869b/pr-6276 Backporting merged PR #6276 into master
🤖 @patchback |
Backport to 3.9: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 47ff9b3 on top of patchback/backports/3.9/47ff9b358bb6147353b1b37b0ac18d641df9869b/pr-6276 Backporting merged PR #6276 into master
🤖 @patchback |
* Check docstrings with flake8-docstrings * Address pydocstyle D2xx issues * Add CHANGES entry * Fix linter Co-authored-by: Andrew Svetlov <[email protected]>
* Check docstrings with flake8-docstrings * Address pydocstyle D2xx issues * Add CHANGES entry * Fix linter Co-authored-by: Andrew Svetlov <[email protected]>
What do these changes do?
As discussed in #6180 (comment), add flake8-docstrings and fix a bunch of issues flagged by it.
Are there changes in behavior for the user?
No.
Related issue number
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.