Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add headers argument to ws_connect() #608

Closed
rutsky opened this issue Oct 29, 2015 · 2 comments
Closed

add headers argument to ws_connect() #608

rutsky opened this issue Oct 29, 2015 · 2 comments
Labels
good first issue Good for newcomers outdated
Milestone
0.20

Comments

@rutsky
Copy link
Member

rutsky commented Oct 29, 2015

WebSocket connection handshake may require passing of additional headers from client to server, for example Authorization header to implement HTTP Basic Auth.

This is a pretty easy bug and can be implemented in similar fashion to PR #607.
@rutsky rutsky mentioned this issue Oct 29, 2015
Merged
@asvetlov asvetlov added the good first issue Good for newcomers label Oct 29, 2015
@asvetlov asvetlov added this to the 0.19 milestone Oct 29, 2015
@asvetlov asvetlov modified the milestones: 0.20, 0.19 Nov 25, 2015
@asvetlov asvetlov mentioned this issue Dec 25, 2015
Merged
@asvetlov
Copy link
Member

Fixed by #709

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers outdated
Projects
None yet
Milestone
0.20
Development

No branches or pull requests
2 participants
@rutsky @asvetlov