Type hint istr keys allowed in LooseHeaders #3976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So one can use e.g. {hdrs.SOMETHING: ...} as headers.
Codecov Report
@@ Coverage Diff @@
## master #3976 +/- ##
==========================================
- Coverage 97.77% 97.75% -0.03%
==========================================
Files 43 43
Lines 8763 8763
Branches 1375 1375
==========================================
- Hits 8568 8566 -2
- Misses 83 84 +1
- Partials 112 113 +1
Continue to review full report at Codecov.
|
asvetlov
requested changes
Aug 12, 2019
psf-chronographer
bot
added
the
bot:chronographer:provided
|
Done. |
|
Thanks! |
asvetlov
pushed a commit
that referenced
this pull request
Aug 15, 2019
(cherry picked from commit ec5aee7) Co-authored-by: Ville Skyttä <[email protected]>
asvetlov
added a commit
that referenced
this pull request
Aug 15, 2019
(cherry picked from commit ec5aee7) Co-authored-by: Ville Skyttä <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Allows one to use e.g. {hdrs.SOMETHING: ...} as headers per type checks.
Are there changes in behavior for the user?
No.
Related issue number
I don't think so.
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.