Header parsing regression in 3.4 w/ empty headers

[hynek]

Long story short

A request containing

finagle-http-retryable-request:
X-TX-ID: abc

will parse to:

'finagle-http-retryable-requestX-TX-ID': 'abc'

Expected behaviour

Not squishing them together like 3.3. :)

Actual behaviour

Squishes together.

Steps to reproduce

Start a simple aiohttp server, then:

nc localhost 5100
POST / HTTP/1.1
Foo:
Bar: x

gives you: <CIMultiDictProxy('FooBar': 'x')>

It doesn’t matter, whether there’s a space behind Foo: or not.

Your environment

aiohttp 3.4.0. 3.3 works fine.

[webknjaz]

Hi @hynek!

Could you please try testing git version (build from source), but downgrade a git submodule in vendor/http-parser about 10 commits back?

[webknjaz]

Oh, it seems @popravich is already working on a fix @ #3218

[asvetlov]

Fixed by #3218

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new