Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise "TooManyRedirects" when redirect to new url with different host #3149

Closed
strongbugman opened this issue Jul 21, 2018 · 2 comments
Closed
Labels

Comments

@strongbugman
Copy link

strongbugman commented Jul 21, 2018

Long story short

As client, host in header is old one(set by hand) when redirect to new url, this may confuse some server and receive 301 response always, until raise TooManyRedirects.

Expected behaviour

Host in header be updated with new url when handle redirect request

Actual behaviour

Host always is old one and receive 301 response until raise Exception.

Steps to reproduce

Request a url which will redirect to different host, example:

await aiohttp.ClientSession().get('http://feedproxy.google.com/~r/PythonInsider/~3/RMqgTQsV720/python-3.html', headers={'Host': 'feedproxy.google.com'})
# raise TooManyRedirects!

Your environment

aiohttp 3.3.2 as client
MacOS 10.13.5

@strongbugman
Copy link
Author

Closed because the aiohttp`s behaviour is right: When user set host in header, client should not change it.(I didn't realize I had passed the host header in my usage, sorry for my thoughtless)

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant