Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aiohttp doesn't use system settings #2963

Closed
lc-thomas opened this issue Apr 27, 2018 · 2 comments
Closed

aiohttp doesn't use system settings #2963

lc-thomas opened this issue Apr 27, 2018 · 2 comments
Labels

Comments

@lc-thomas
Copy link

Long story short

aiohttp doesn't use system proxy settings

Expected behaviour

aiohttp should use system proxy settings

Actual behaviour

aiohttp doesn't use system proxy settings

Steps to reproduce

Set a system proxy : export http_proxy="your_proxy"
Make a request using aiohttp

Your environment

aiohttp client - Debian

@asvetlov
Copy link
Member

asvetlov commented Apr 27, 2018

aiohttp shouldn't use system proxy settings. It is insecure.
Use trust_env=True explicitly: https://docs.aiohttp.org/en/stable/client_advanced.html?highlight=trust_env#proxy-support

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants