Deprecate app.make_handler() in favor of runners API

[asvetlov]

Don't change internal logic a lot but add app._make_handler() internal method and reuse it by runners.
More intrusive changes can be done after app.make_handler() removal.
Document app.make_handler() as deprecated, drop the usage from logging.rst and testing.rst.

[asvetlov]

The issue is mostly about documentation update (and a little coding).
A volunteer is welcome!

[xstrengthofonex]

I'd like to do this, but would it possible to get some more information about this change. So you want to depreciate the use of app._make_handler() as a "public" api and rename it to app._make_handler()? But the behavior shouldn't be changed right? as the method is still used by AppRunner.

How about the tests inside test_web_app? When I changed the method name to app._handle_request() they kept failing despite changing the method names in the tests.

Also what is the convention for depreciating a method? I couldn't find any example when I looked through the documentation. Is it the .. versionchanged:: 3.2 and then a note about the specific change?

[asvetlov]

The step-by-step instruction is:

1. Rename .make_handler() to ._make_handler()
2. Fix tests and code to use app._make_handler()
3. Add Application.make_handler() back, the method should raise DeprecationWarning like here

   aiohttp/aiohttp/payload_streamer.py

   Lines 47 to 49 in 80c0e5f

   	warnings.warn("@streamer is deprecated, use async generators instead",
   	DeprecationWarning,
   	stacklevel=2)

   and call ._make_handler().
4. Add .. deprecated:: 3.2 to documentation.
5. Add xxx.removal file to CHANGES.

[xstrengthofonex]

Thank you for the clarification. I'll get to work

[asvetlov]

Fixed by #2938

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new