You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
sorry, my implementation of websocket subprotocols has a mistake, i.e. the spec says:
The server selects one or none of the acceptable protocols and echoes that value in its handshake to indicate that it has selected that protocol.
so instead of a Bad Request exception, we should send back no Sec-WebSocket-Protocol header at all and leave it to the client to drop the connection or carry on without protocol (however dumb that sounds).
The text was updated successfully, but these errors were encountered:
gladly. i see that this project doesn’t use logging: wouldn’t it be useful to introduce it? then i could replace this with a warning, but it doesn’t make sense if we don’t log anything else.
sorry, my implementation of websocket subprotocols has a mistake, i.e. the spec says:
so instead of a Bad Request exception, we should send back no
Sec-WebSocket-Protocol
header at all and leave it to the client to drop the connection or carry on without protocol (however dumb that sounds).The text was updated successfully, but these errors were encountered: