From 752f8b58b3d80fd1626781e0c73897b699bf2296 Mon Sep 17 00:00:00 2001 From: Jakob Keller <57402305+jakob-keller@users.noreply.github.com> Date: Thu, 16 May 2024 21:14:59 +0200 Subject: [PATCH] Address breaking change introduced in `aiohttp==3.9.2` (#1081) --- .github/workflows/python-package.yml | 2 +- CHANGES.rst | 4 ++++ aiobotocore/__init__.py | 2 +- aiobotocore/httpsession.py | 3 +-- setup.py | 2 +- tests/test_version.py | 2 +- 6 files changed, 9 insertions(+), 6 deletions(-) diff --git a/.github/workflows/python-package.yml b/.github/workflows/python-package.yml index f9cc0f11..a265a89a 100644 --- a/.github/workflows/python-package.yml +++ b/.github/workflows/python-package.yml @@ -21,7 +21,7 @@ jobs: matrix: python-version: ['3.8', '3.9', '3.10', '3.11', '3.12'] include: - - aiohttp-version: '==3.7.4.post0' + - aiohttp-version: '==3.9.2' - aiohttp-version: '<4.0.0' python-version: '3.11' fail-fast: false diff --git a/CHANGES.rst b/CHANGES.rst index c0945a19..4de721d0 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -1,6 +1,10 @@ Changes ------- +2.13.0 (2024-05-16) +^^^^^^^^^^^^^^^^^^^ +* address breaking change introduced in `aiohttp==3.9.2` #882 + 2.12.4 (2024-05-16) ^^^^^^^^^^^^^^^^^^^ * bump botocore dependency specification diff --git a/aiobotocore/__init__.py b/aiobotocore/__init__.py index 95515d62..2321a43e 100644 --- a/aiobotocore/__init__.py +++ b/aiobotocore/__init__.py @@ -1 +1 @@ -__version__ = '2.12.4' +__version__ = '2.13.0' diff --git a/aiobotocore/httpsession.py b/aiobotocore/httpsession.py index c8c3fe41..4c527fb5 100644 --- a/aiobotocore/httpsession.py +++ b/aiobotocore/httpsession.py @@ -166,8 +166,7 @@ def _create_connector(self, proxy_url): return aiohttp.TCPConnector( limit=self._max_pool_connections, - verify_ssl=bool(self._verify), - ssl=ssl_context, + ssl=ssl_context or False, **self._connector_args, ) diff --git a/setup.py b/setup.py index 1c8a3ad9..1821f690 100644 --- a/setup.py +++ b/setup.py @@ -8,7 +8,7 @@ install_requires = [ # pegged to also match items in `extras_require` 'botocore>=1.34.70,<1.34.107', - 'aiohttp>=3.7.4.post0,<4.0.0', + 'aiohttp>=3.9.2,<4.0.0', 'wrapt>=1.10.10, <2.0.0', 'aioitertools>=0.5.1,<1.0.0', ] diff --git a/tests/test_version.py b/tests/test_version.py index 79cde86a..e45fcdb4 100644 --- a/tests/test_version.py +++ b/tests/test_version.py @@ -161,7 +161,7 @@ def test_release_versions(): rst_prev_date = datetime.strptime(rst_prev_date, '%Y-%m-%d').date() assert ( - rst_date > rst_prev_date + rst_date >= rst_prev_date ), 'Current release must be after last release' # get aioboto reqs