This repository has been archived by the owner on Feb 21, 2023. It is now read-only.
#464 Make pipeline sending all commands in a single step #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
gjcarneiro
reviewed
Oct 1, 2018
| @@ -273,6 +273,32 @@ def _process_pubsub(self, obj, *, process_waiters=True): | |||
| else: | |||
| logger.warning("Unknown pubsub message received %r", obj) | |||
|
|
|||
| def execute_pipeline(self, pipeline_cmds, encoding=_NOTSET): | |||
| cmds = [] | |||
There was a problem hiding this comment.
You should probably use bytearray here. List joining was what asyncio StreamWriter used to do as well, then they found that bytearray was more efficient. This is what bytearray was designed for, actually...
|
I'm sorry, but I'm closing this PR in favour of #473. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch for describing problem in #464 issue