#231 Patch for the cpython issue with Lock bpo-27585 #241
Conversation
Codecov Report
@@ Coverage Diff @@
## master #241 +/- ##
==========================================
+ Coverage 96.97% 96.99% +0.02%
==========================================
Files 55 57 +2
Lines 7492 7449 -43
Branches 625 587 -38
==========================================
- Hits 7265 7225 -40
+ Misses 168 167 -1
+ Partials 59 57 -2
Continue to review full report at Codecov.
|
|
@popravich any interest in bake a minor release with that fix? |
aioredis/locks.py
Outdated
| raise | ||
| finally: | ||
| self._waiters.remove(fut) | ||
| else: |
There was a problem hiding this comment.
Why do you need two versions of Lock?
There was a problem hiding this comment.
since Python 3.5 there were some small changes in that function, I've preferred to keep both versions separately to make it readable and of course, pass the tests with all Python 3 versions.
There was a problem hiding this comment.
well, that changes were actually fixing another cancellation issue python/asyncio#393
There was a problem hiding this comment.
yes, a shame of me. Take a look to the last commit, unified to a unique function that should be compatible with all Python versions and free of issues.
|
what about a minor release with that fix? |
|
+1, also interested on trying a version with the new fixes :) |
|
In the middle of a process, give me a moment) |
|
New versions ( |
|
thanks ! |
Copied and adapted code from the PR pending to be merged yet [1]
[1] python/cpython#1031