Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing [] and {} as argument. #328

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Allow passing [] and {} as argument. #328

merged 1 commit into from
Sep 20, 2024

Conversation

superstar54
Copy link
Member

@superstar54 superstar54 commented Sep 19, 2024

Fix a couple of bugs:

  • Add merge_dict function to merge dict correctly
  • Reset child tasks for Zone task
  • Skip running task if the task is in SKIPPED state

Add `merge_dict` function to merge dict correctly
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.62%. Comparing base (5937b88) to head (4260f2d).
Report is 77 commits behind head on main.

Files with missing lines Patch % Lines
aiida_workgraph/engine/workgraph.py 66.66% 2 Missing ⚠️
aiida_workgraph/utils/__init__.py 88.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
+ Coverage   75.75%   80.62%   +4.87%     
==========================================
  Files          70       66       -4     
  Lines        4615     5147     +532     
==========================================
+ Hits         3496     4150     +654     
+ Misses       1119      997     -122     
Flag Coverage Δ
python-3.11 80.55% <84.61%> (+4.88%) ⬆️
python-3.12 80.55% <84.61%> (?)
python-3.9 80.58% <84.61%> (+4.84%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superstar54 superstar54 merged commit 64bc906 into main Sep 20, 2024
8 checks passed
@superstar54 superstar54 deleted the fix/merge_dict branch September 20, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants