FolderData: Expose repository API on top-level namespace
#6150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 8293e45, the `Node` interface was refactored to move the API of the repository to the `base.repository` namespace. The original methods would be forwarded with a deprecation message being printed. Although this made sense for most node types, in an effort to clean up the node interface which was overpopulated, for the `FolderData` the repository interface is the main interface and it doesn't make sense to force the users to go all the way down to the nested `base.repository` namespace to access it. Therefore the public API of the repository is restored on the top-level namespace of the `FolderData` class.
sphuber
force-pushed
the
feature/folder-data-api
branch
5 times, most recently
from
a5de98f
to
9180b4a
Compare
giovannipizzi
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 8293e45, the
Nodeinterface was refactored to move the API of the repository to thebase.repositorynamespace. The original methods would be forwarded with a deprecation message being printed.Although this made sense for most node types, in an effort to clean up the node interface which was overpopulated, for the
FolderDatathe repository interface is the main interface and it doesn't make sense to force the users to go all the way down to the nestedbase.repositorynamespace to access it. Therefore the public API of the repository is restored on the top-level namespace of theFolderDataclass.