♻️ REFACTOR: Remove Entity.from_backend_entity from the public API
#5447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphuber
force-pushed
the
orm-node-from_backend_entity
branch
3 times, most recently
from
99430d2
to
9d603b5
Compare
Move it to a standalone function in `aiida.orm.entities`.
sphuber
force-pushed
the
orm-node-from_backend_entity
branch
from
9d603b5
to
962bfff
Compare
sphuber
approved these changes
Dec 14, 2022
There was a problem hiding this comment.
Thanks @chrisjsewell . I have rebased the branch and addressed the merge conflicts. Good for me to merge
|
@sphuber you know we are in a meeting right now 😉 |
but yeh go for it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should not be exposed on the public API, for e.g.
Node(see #4976).Instead, we move it to a pure function.
Note, you could rename to
Entity._from_backend_entity, but this generates numerous pylintprotected-accesswarnings