Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 MAINTAIN: Pin itsdangerous #5365

Closed
wants to merge 1 commit into from
Closed

Conversation

chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Feb 18, 2022

itsdangerous just released 2.1.0, which drops itsdangerous.json: https://itsdangerous.palletsprojects.com/en/2.1.x/changes/#version-2-1-0
This is incompatible with flask 1.x (in the rest extra)

Incidentally, whilst looking at this, I noted that aiida-core actually only installs flask<=1.1.2, because that has no upper pins on dependencies, whereas aiida-core is incompatible with flask>=1.1.3 because of the click/jinja upper versions it pins:
https://github.com/pallets/flask/blob/c04b0de558fe8e1ccb8edb4525d40e725ae9a24d/setup.py#L55-L59
(flask v2 is also out)

Given the rest code is eventually intended to be deprecated for aiida-restapi, I wouldn't be too worried though

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #5365 (03f7d8e) into develop (da5f9b0) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5365      +/-   ##
===========================================
+ Coverage    79.46%   79.46%   +0.01%     
===========================================
  Files          513      513              
  Lines        36755    36755              
===========================================
+ Hits         29202    29203       +1     
+ Misses        7553     7552       -1     
Impacted Files Coverage Δ
aiida/transports/plugins/local.py 81.71% <0.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da5f9b0...03f7d8e. Read the comment docs.

csadorf
csadorf previously approved these changes Feb 18, 2022
@sphuber
Copy link
Contributor

sphuber commented Feb 18, 2022

Would the REST API be compatible with flask 2.0? If so, might make more sense to just update to that no? Please hold with merging for a bit

@sphuber
Copy link
Contributor

sphuber commented Feb 18, 2022

I checked updating to flask~=2.0 here and tests work, so I would actually advise that. That version of flask has been out for almost a year

@csadorf csadorf dismissed their stale review February 18, 2022 08:22

Looks like updating flask might be an option based on sphuber's test.

@ltalirz ltalirz removed their request for review February 18, 2022 09:34
@sphuber
Copy link
Contributor

sphuber commented Feb 18, 2022

Superseded by #5366

@sphuber sphuber closed this Feb 18, 2022
@sphuber sphuber deleted the pin-itsdangerous branch February 18, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants