Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename node class for workfunctions #2189

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Nov 12, 2018

The node class used by workfunction changed from FunctionCalculation to
WorkFunctionNode.

Copy link
Contributor

@muhrin muhrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@sphuber sphuber force-pushed the fix_2169_rename_workfunction_nodes branch 4 times, most recently from 9840c70 to 21f2be7 Compare November 12, 2018 15:30
@coveralls
Copy link

coveralls commented Nov 12, 2018

Coverage Status

Coverage decreased (-1.4%) to 65.809% when pulling 26a2a66 on sphuber:fix_2169_rename_workfunction_nodes into 13c57b9 on aiidateam:provenance_redesign.

The node class used by workfunction changed from `FunctionCalculation` to
`WorkFunctionNode`.
@sphuber sphuber force-pushed the fix_2169_rename_workfunction_nodes branch from 21f2be7 to 26a2a66 Compare November 12, 2018 16:22
@sphuber sphuber merged commit 28e2231 into aiidateam:provenance_redesign Nov 12, 2018
@sphuber sphuber deleted the fix_2169_rename_workfunction_nodes branch November 12, 2018 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants