build_call_graph shows 'NoneType' object has no attribute 'value'

[superstar54]

Steps to reproduce

from aiida.cmdline.utils.ascii_vis import build_call_graph

I called build_call_graph every three seconds to get the status of a process. This is used to update the GUI in AiiDAlab.

At some point (in rare case, randomly), I got this error:

    process_status = build_call_graph(node)
                     ^^^^^^^^^^^^^^^^^^^^^^
  File "/home/xing/apps/miniforge3/envs/aiida/lib/python3.11/site-packages/aiida/cmdline/utils/ascii_vis.py", line 96, in build_call_graph
    return info_string, [
                        ^
  File "/home/xing/apps/miniforge3/envs/aiida/lib/python3.11/site-packages/aiida/cmdline/utils/ascii_vis.py", line 97, in <listcomp>
    build_call_graph(c, max_depth=max_depth, call_link_label=call_link_label, info_fn=info_fn) for c in called
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/xing/apps/miniforge3/envs/aiida/lib/python3.11/site-packages/aiida/cmdline/utils/ascii_vis.py", line 96, in build_call_graph
    return info_string, [
                        ^
  File "/home/xing/apps/miniforge3/envs/aiida/lib/python3.11/site-packages/aiida/cmdline/utils/ascii_vis.py", line 97, in <listcomp>
    build_call_graph(c, max_depth=max_depth, call_link_label=call_link_label, info_fn=info_fn) for c in called
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/xing/apps/miniforge3/envs/aiida/lib/python3.11/site-packages/aiida/cmdline/utils/ascii_vis.py", line 96, in build_call_graph
    return info_string, [
                        ^
  File "/home/xing/apps/miniforge3/envs/aiida/lib/python3.11/site-packages/aiida/cmdline/utils/ascii_vis.py", line 97, in <listcomp>
    build_call_graph(c, max_depth=max_depth, call_link_label=call_link_label, info_fn=info_fn) for c in called
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/xing/apps/miniforge3/envs/aiida/lib/python3.11/site-packages/aiida/cmdline/utils/ascii_vis.py", line 96, in build_call_graph
    return info_string, [
                        ^
  File "/home/xing/apps/miniforge3/envs/aiida/lib/python3.11/site-packages/aiida/cmdline/utils/ascii_vis.py", line 97, in <listcomp>
    build_call_graph(c, max_depth=max_depth, call_link_label=call_link_label, info_fn=info_fn) for c in called
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/xing/apps/miniforge3/envs/aiida/lib/python3.11/site-packages/aiida/cmdline/utils/ascii_vis.py", line 90, in build_call_graph
    info_string = info_fn(calc_node, call_link_label)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/xing/apps/miniforge3/envs/aiida/lib/python3.11/site-packages/aiida/cmdline/utils/ascii_vis.py", line 32, in calc_info
    process_state = node.process_state.value.capitalize()
                    ^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'value'

[agoscinski]

The process_state can be None

aiida-core/src/aiida/orm/nodes/process/process.py

Line 359 in e1467ed

def process_state(self) -> Optional[ProcessState]:

so the function

aiida-core/src/aiida/cmdline/utils/ascii_vis.py

Line 32 in e1467ed

process_state = node.process_state.value.capitalize()

should handle this case. That is the easy fix to not let it crash.

The harder fix is to figure out why the process_state is None. The only entry point I know for creating a process is when they are run or submitted, but in this case they should be directly in state Created, after that the process state is never set to None AFAIK. If no one has an idea we can first implement the above fix. When the application does not crash, we might get more information.