Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Untested method: load_backend_if_not_loaded #4868

Closed
ramirezfranciscof opened this issue Apr 26, 2021 · 0 comments · Fixed by #5438
Closed

Untested method: load_backend_if_not_loaded #4868

ramirezfranciscof opened this issue Apr 26, 2021 · 0 comments · Fixed by #5438
Assignees
@ramirezfranciscof
Labels
good first issue Issues that should be relatively easy to fix also for beginning contributors priority/nice-to-have topic/testing type/enhancement

Comments

@ramirezfranciscof
Copy link
Member

Location: aiida.cmdline.utils.decorators

The method loads the DB environment only when it is necessary. We still need to test that it actually avoids doing it when it is not. An idea of how to do so from #4865:

we would have to mock the database loading env by a function that counts the number of times it is called with a global and raises the second time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ramirezfranciscof ramirezfranciscof

Labels
good first issue Issues that should be relatively easy to fix also for beginning contributors priority/nice-to-have topic/testing type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

load_backend_if_not_loaded: test get_profile_storage is called just once sphuber/aiida-core
1 participant
@ramirezfranciscof