Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: consider switching to sphinx-book-theme #4441

Open
ltalirz opened this issue Oct 14, 2020 · 6 comments
Open

docs: consider switching to sphinx-book-theme #4441

ltalirz opened this issue Oct 14, 2020 · 6 comments
Assignees

Comments

@ltalirz
Copy link
Member

ltalirz commented Oct 14, 2020

As shown by @chrisjsewell , the sphinx-book-theme offers a couple of nices features, including:

  • suggesting edits
  • opening issue for the page one is looking at
  • downloading a page as PDF

I'm interested particularly in lowering the barrier for users to give feedback on the documentation - part of it is perhaps just textual: we currently have an "edit this page" button
image
but I think "suggest edit" is actually what we want people to see.
Having a way to open an issue on a particular documentation page also seems like a very good idea.

I just discussed with @chrisjsewell and he suggested to wait a few weeks until there is a stable release.

It should mainly just be replacing pydata-sphinx-theme with sphinx-book-theme

@ltalirz ltalirz added the type/feature request status undecided label Oct 14, 2020
@chrisjsewell
Copy link
Member

Yep FYI: sphinx-book-theme literally inherits from pydata-sphinx-theme, so it should be too difficult to change over in a test branch see what the docs look like.
We've got a few imminent improvements in the pipeline, which is why I suggested to wait just a little bit

@chrisjsewell
Copy link
Member

Note, sphinx-book-theme is just about there now with the improvements I mentioned (by moi as one of its maintainers): https://sphinx-book-theme.readthedocs.io/en/latest/ (e.g. expandable sections in the left ToC), and as mentioned in #5006, @mbercx has already taken the plunge to use it in https://aiida-tutorials.readthedocs.io/en/tutorial-2021-intro/ 😄

@mbercx
Copy link
Member

mbercx commented Jul 7, 2021

@mbercx has already taken the plunge to use it in https://aiida-tutorials.readthedocs.io/en/tutorial-2021-intro/ 😄

And a deep dive it was 😅

@ltalirz
Copy link
Member Author

ltalirz commented Dec 8, 2021

@chrisjsewell Is there any reason to wait more for this or is this switch up for grabs?

@chrisjsewell
Copy link
Member

@ltalirz
Copy link
Member Author

ltalirz commented Feb 19, 2022

@chrisjsewell will take care of this once sphinx-book-theme has further consolidated, see #5368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants