Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST API dependencies: are all of them needed? #3528

Closed
giovannipizzi opened this issue Nov 8, 2019 · 0 comments · Fixed by #3597
Closed

REST API dependencies: are all of them needed? #3528

giovannipizzi opened this issue Nov 8, 2019 · 0 comments · Fixed by #3597
Assignees

Comments

@giovannipizzi
Copy link
Member

There are quite a few dependencies in the rest extra. I'm not sure I understand, however, if they are all used and how. Maybe some of them are just "plugins" for flask and just need to be there, but could you:

  • check if there are any dependencies that are not really needed, and remove them
  • report here which one are used, how (i.e. if they are imported or used implicitly) and, especially in the latter case, what are they needed for?

Just to make two examples, if I do git grep marshmallow I don't get any hit in python files, but there are the dependencies flask-marshmallow==0.10.1 and marshmallow-sqlalchemy==0.19.0 - are they used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants