Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update verdi import #2857

Closed
3 tasks
CasperWA opened this issue May 10, 2019 · 1 comment
Closed
3 tasks

Update verdi import #2857

CasperWA opened this issue May 10, 2019 · 1 comment
Labels
good first issue Issues that should be relatively easy to fix also for beginning contributors priority/quality-of-life would simplify development topic/verdi type/refactoring

Comments

@CasperWA
Copy link
Contributor

As mentioned here:

Suggestions to update verdi import code (by @ltalirz):

  • archives should simply be processed one by one (there is no need to create and validate the full list of archives before you even start. e.g. rm file1 file2 file3 also will start removing files and only stop when it encounters a file that isn't there)
  • when you look at an archive you figure out whether it's a url or not. if url, validate URL and call function to download. you replace url by path to downloaded file and the following code runs inside a sandbox folder
  • from now on all code is shared...
@CasperWA CasperWA added good first issue Issues that should be relatively easy to fix also for beginning contributors topic/verdi priority/quality-of-life would simplify development type/refactoring aiida-core 1.x labels May 10, 2019
@CasperWA CasperWA added this to the v1.1.0 milestone May 10, 2019
@sphuber sphuber removed this from the v1.1.0 milestone Feb 28, 2020
@chrisjsewell
Copy link
Member

I think this was all addressed in #4532, but feel free to re-open if you think there is room for improvement 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues that should be relatively easy to fix also for beginning contributors priority/quality-of-life would simplify development topic/verdi type/refactoring
Projects
None yet
Development

No branches or pull requests

3 participants