Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken backwards compatibility of KpointsData introduced by Seekpath implementation #1046

Closed
sphuber opened this issue Jan 15, 2018 · 1 comment
Closed

Fix broken backwards compatibility of KpointsData introduced by Seekpath implementation #1046

sphuber opened this issue Jan 15, 2018 · 1 comment
Assignees
@greschd @giovannipizzi
Labels
priority/critical-blocking must be resolved before next release type/bug
Milestone
v0.11.0

Comments

@sphuber
Copy link
Contributor

sphuber commented Jan 15, 2018

PR #1015 deprecated various methods of KpointsData and exposed a common interface that by default would select to use the Seekpath library. However, the change broke backwards compatibility of the set_kpoints_path method. Originally, for cartesian=False and certain formats of the kpoints path it was not required to have defined a cell, however, the deprecation interface now always raises when the cell is not set.
@sphuber sphuber added type/bug priority/critical-blocking must be resolved before next release labels Jan 15, 2018
@sphuber sphuber added this to the v0.11.0 milestone Jan 15, 2018
@sphuber sphuber mentioned this issue Jan 15, 2018
Merged
@giovannipizzi
Copy link
Member

Fixed by #1047

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greschd greschd

@giovannipizzi giovannipizzi

Labels
priority/critical-blocking must be resolved before next release type/bug
Projects
None yet
Milestone
v0.11.0
Development

No branches or pull requests
3 participants
@greschd @sphuber @giovannipizzi