Chore: drop Node v < 10 | Move from ava to jest #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should drop Node v4 and v6 and support only Node v10 and v12. Then appveyor should go green |
|
That sounds right. Don't forget to change the node versions for the travis build as well. |
JPeer264
changed the title
JPeer264
changed the title
|
@aichbauer appveyor works now with jest, but the coverage is just more strict than before (imports are not included in the coverage), that's why coveralls is now dropping 2.5% |
|
No problem. Send from GitHub Android App 😱 |
aichbauer
approved these changes
Mar 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(ref: appveyor/ci#2921 (comment))