Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fv3fit tests require GCS access #902

Closed
nbren12 opened this issue Jan 13, 2021 · 1 comment · Fixed by #916
Closed

fv3fit tests require GCS access #902

nbren12 opened this issue Jan 13, 2021 · 1 comment · Fixed by #916

Comments

@nbren12
Copy link
Contributor

nbren12 commented Jan 13, 2021

The tests in in tests/training/test_train_keras.py need access to GCS (probably for the grid information). To open-source this repo we should remove this data dependency from fv3fit.
@AnnaKwa
Copy link
Contributor

AnnaKwa commented Jan 15, 2021

I can remove this dependency. I'll add an if statement so that the derived dataset only accesses the grid data if the variables requested rely on it.

@AnnaKwa AnnaKwa mentioned this issue Jan 16, 2021
Merged
1 task
@nbren12 nbren12 mentioned this issue Jan 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Loaders only access GCS grid data when necessary ai2cm/fv3net
2 participants
@nbren12 @AnnaKwa