Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang++ version restricton #109

Open
gunjannandy opened this issue Nov 23, 2019 · 0 comments
Open

clang++ version restricton #109

gunjannandy opened this issue Nov 23, 2019 · 0 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@gunjannandy
Copy link
Contributor

Problem

If we specify clang++ verison 8 in Makefile.common like this:

/usr/bin/clang++-8

It won't work in clang++-9 though version 9 is supported.
But clang versions below 8 doesn't support aggregate expression. See below error:

dnnCompiler/include/operators/GlobalAveragePool.h:61:54: error: cannot compile this
      aggregate expression yet
    eResult = eigenTensor.mean(Eigen::array<int, 1>({2}));

Workarounds

  • Use cMake.
    • By doing this we will be supporting Windows natively (without docker).
  • Change the aggregate expression so that our compilation has backward compatiability.
    • By doing this we will be supporting Mac OS natively (without docker).

Solution

Implement both the above mentioned workarounds, to fully close this issue!

@gunjannandy gunjannandy added bug Something isn't working enhancement New feature or request labels Nov 23, 2019
@gunjannandy gunjannandy self-assigned this Nov 23, 2019
@srohit0 srohit0 self-assigned this Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants