Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary package for windows #139

Closed
julian-r opened this issue Aug 17, 2017 · 5 comments · May be fixed by #294
Closed

Binary package for windows #139

julian-r opened this issue Aug 17, 2017 · 5 comments · May be fixed by #294

Comments

@julian-r
Copy link

julian-r commented Aug 17, 2017

Are you open to create a wheel package for windows delivering all the binary deps?
(I would do it and send you a PR)

@julian-r
Copy link
Author

I created a project which aims to produce binaries for windows of current file version here: https://github.com/julian-r/file-windows

@ahupp
Copy link
Owner

ahupp commented Oct 2, 2017

I'm not that familiar with how this works on windows. What would this look like for users? My preference TBH is to have a separate package with the binaries with really good documentation for setup.

@julian-r
Copy link
Author

julian-r commented Oct 9, 2017

Ok, I've made a branch available here: https://github.com/julian-r/python-magic. It offers a windows 32/64 bit binary and a mac binary. Also uploaded it to the pypi.
https://pypi.python.org/pypi/python-magic-bin/0.4.14

IMHO the advantage is pip install and it just works, otherwise is such a hassle of getting the right shared libraries and everything.

@mengzxh
Copy link

mengzxh commented Nov 2, 2017

Thanks, I have solve it.

@ahupp
Copy link
Owner

ahupp commented Aug 25, 2023

Merging into #293

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants